Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] 공지 border 라인 마진 및 대표학과 칩 UI #203

Merged
merged 5 commits into from
Apr 14, 2024
Merged

[2.0.0] 공지 border 라인 마진 및 대표학과 칩 UI #203

merged 5 commits into from
Apr 14, 2024

Conversation

lgvv
Copy link
Member

@lgvv lgvv commented Apr 14, 2024 •
edited
Loading

스크린샷

보더라인 수정 대표 칩
보더라인 대표학과

|

@lgvv lgvv requested a review from x-0o0 April 14, 2024 07:13
@lgvv lgvv self-assigned this Apr 14, 2024
@lgvv lgvv added the v2 label Apr 14, 2024
@lgvv
Copy link
Member Author

lgvv commented Apr 14, 2024

/쿠링 패키지 빌드

@github-actions GitHub Actions
Copy link

🔨 iOS 17.0.1 iPhone 15 Pro 에서 스위프트 패키지를 빌드합니다.

@github-actions GitHub Actions
Copy link

✅ 패키지를 성공적으로 빌드했습니다.

@x-0o0 x-0o0 self-requested a review April 14, 2024 11:33
x-0o0
x-0o0 approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@x-0o0 x-0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wonniiii
wonniiii approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@wonniiii wonniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ! 저도 이제 네이밍 신경써야겠네요...!

@lgvv
Copy link
Member Author

lgvv commented Apr 14, 2024

/쿠링 머지

@github-actions github-actions bot added the automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. label Apr 14, 2024
@github-actions github-actions bot merged commit a07e026 into develop/2.0.0 Apr 14, 2024
@github-actions GitHub Actions
Copy link

🕊️ PR #203이 머지되었습니다.

@github-actions github-actions bot deleted the feature/lgvv/banner-lib branch April 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonniiii wonniiii wonniiii approved these changes

@x-0o0 x-0o0 x-0o0 approved these changes

@sunshiningsoo sunshiningsoo Awaiting requested review from sunshiningsoo

Assignees

@lgvv lgvv

Labels
automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgvv @x-0o0 @wonniiii